fix(instantsearch.js): prevent authenticated token being set as the userToken
#6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Haroenv
reviewed
Nov 19, 2024
packages/instantsearch.js/src/middlewares/createInsightsMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/middlewares/__tests__/createInsightsMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/middlewares/createInsightsMiddleware.ts
Outdated
Show resolved
Hide resolved
Haroenv
approved these changes
Nov 20, 2024
|
@shaejaz, best not to merge this right now yet as we may be needing a hotfix during code freeze and then I'd rather not have this change in it yet |
|
@Haroenv makes sense 👍. Should I label this with 'do not merge' ? |
Haroenv
added
the
🚨 DO NOT MERGE
dhayab
removed
the
🚨 DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The authenticated user token from insights should no longer be used as the
userTokenfor the search API. This PR removes all listeners and usage ofauthenticatedUserTokenin the insights middleware.FX-3159