feat(experiences): implement custom element #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
Haroenv,
a team and
dhayab
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c88b163:
|
Haroenv
approved these changes
Sep 17, 2024
Haroenv
approved these changes
Sep 18, 2024
Comment on lines
+73
to
+74
| this.disconnectedCallback(); | ||
| this.connectedCallback(); |
There was a problem hiding this comment.
for later: the order should be fetch -> remove -> add, not remove -> fetch -> add, but I see how this current code is much simpler
There was a problem hiding this comment.
Could be simple, I could wrap this into fetchConfiguration(newValue).then and it would pick up the cached configuration in connectedCallback
| class AlgoliaExperience extends HTMLElement { | ||
| static observedAttributes = ['experience-id']; | ||
|
|
||
| widgets: IndexWidget[] = []; | ||
|
|
||
| connectedCallback() { | ||
| const experienceId = this.getAttribute('experience-id'); | ||
| if (!experienceId) { | ||
| const id = this.getAttribute('experience-id'); |
There was a problem hiding this comment.
would there be less repetition if we call the attribute data-id? can swap before the GA still
shaejaz
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-3008
Summary
To allow usage within an SPA, be it completely client-side rendered or not (with Next.js for example), we need to provide a way for an experience to be loaded at any time.
Result
Created a custom element that fetches its own configuration and renders. Code looks a bit awkward since I reused functions meant for multiple configurations.
We should probably implement some caching later for configurations.