Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiences): add separate banner component #6356

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Sep 10, 2024

Summary

adds a separate banner "widget" (uses connectHits) and ensures banner doesn't show inside hits

Result

FX-3002

@Haroenv Haroenv requested review from a team, dhayab and sarahdayan and removed request for a team September 10, 2024 13:08
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7987eb8:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@dhayab
Copy link
Member

dhayab commented Sep 11, 2024

This implementation doesn't read from renderingContent.widgets.banner but instead relies on an explicit banner block, is that right?

@Haroenv
Copy link
Contributor Author

Haroenv commented Sep 11, 2024

@dhayab it reads from renderingContent still, but is a separate widget from the hits widget

@dhayab
Copy link
Member

dhayab commented Sep 11, 2024

Oh I misread it, I see now it uses connectHits as the basis as well. Good for me then!

@Haroenv Haroenv merged commit 9c6bd28 into master Sep 11, 2024
13 of 14 checks passed
@Haroenv Haroenv deleted the feat/exp-banner branch September 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants