Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): use client.search in sffv for v5 #6354

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Sep 10, 2024

Summary

v5 has a searchForFacetValues function, but it's single-index only. We thus need to detect it and use client.search directly. In a future major we can change this and only use client.search

Result

fixes algolia/algoliasearch-client-javascript#1550

v5 has a `searchForFacetValues` function, but it's single-index only. We thus need to detect it and use `client.search` directly. In a future major we can change this and only use `client.search`
@Haroenv Haroenv requested review from a team, dhayab and sarahdayan and removed request for a team September 10, 2024 09:02
Copy link

codesandbox-ci bot commented Sep 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1f8acd:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@Haroenv Haroenv merged commit 11399e6 into master Sep 10, 2024
14 checks passed
@Haroenv Haroenv deleted the fix/client-v5-sffv branch September 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: v5.3.0 - search client instance type is not compatible with react-instant search v7.13.0
2 participants