feat(infinite-hits): return banner info with connectInfiniteHits #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e3bea56:
|
taylorcjohnson
commented
Jun 6, 2024
packages/instantsearch.js/src/connectors/infinite-hits/connectInfiniteHits.ts
Outdated
Show resolved
Hide resolved
taylorcjohnson
requested review from
a team,
dhayab,
sarahdayan and
aymeric-giraudet
and removed request for
a team
aymeric-giraudet
approved these changes
Jun 10, 2024
Haroenv
approved these changes
Jun 10, 2024
packages/instantsearch.js/src/connectors/infinite-hits/connectInfiniteHits.ts
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea89ef6:
|
Haroenv
approved these changes
Jun 11, 2024
aymeric-giraudet
deleted the
feat/infinite-hits/connectInfiniteHits-returns-banner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on from the recent addition of the rules controlled banner to
Hits, we're adding the same toInfiniteHits. This first PR returns banner information withconnectInfiniteHits.https://algolia.atlassian.net/browse/EMERCH-1509
Result
Updated and passing test (no UI changes)