fix(toggleRefinement): don't set off value in getWidgetRenderState #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in the migration from render to getWidgetRenderState, but actually getWidgetSearchParameters already takes this in account, and i can't find any situations where "off" gets erased. Added a test to make sure getWidgetAttribute works when "off" is given, but it's straightforward now
Haroenv
requested review from
a team,
tkrugg and
francoischalifour
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a77530e:
|
francoischalifour
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was added in the migration from render to getWidgetRenderState, but actually getWidgetSearchParameters already takes this in account, and i can't find any situations where "off" gets erased.
Added a test to make sure getWidgetAttribute works when "off" is given, but it's straightforward now
Result
Nothing really changes, except toggle with an off works in dynamic widgets works now and a little bit less code