Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es): add warning to typescript declaration of keys to be imported from helpers #4908

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Sep 15, 2021

Summary

We deprecated the properties added to instantsearch in #4814, but the deprecation does not mention the solution

Result

The same solution as at runtime is given by typescript, importing from ./helpers

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71a9c31:

Sandbox Source
InstantSearch.js Configuration

@Haroenv Haroenv merged commit 8cbd5fb into master Sep 16, 2021
@Haroenv Haroenv deleted the feat/es-import-ts-warn branch September 16, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants