feat(typescript): expose types at regular build #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves away from -experimental and to stable. Note that, like every type change, this could be a breaking change, as manually defined definitions will now merge with the ones provided by InstantSearch. In almost all cases manual definitions or changes made are no longer needed, if you do however see any problems, please open an issue or pull request with reproduction.
Haroenv
commented
Aug 16, 2021
| @@ -32,10 +34,6 @@ | |||
| "addToApiReportFile": true | |||
| }, | |||
|
|
|||
| "ae-internal-missing-underscore": { | |||
There was a problem hiding this comment.
this didn't actually error anymore since a while already
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79119d9:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The typescript migration is complete
This PR moves away from -experimental and to stable.
Result
InstantSearch is now shipped with type definitions built-in!
Note that, like every type change, this could be a breaking change, as manually defined definitions will now merge with the ones provided by InstantSearch.
In almost all cases manual definitions or changes made are no longer needed, if you do however see any problems, please open an issue or pull request with reproduction.
If you were using -experiemental-typescript tag up to now, that can be changed to a regular InstantSearch version from this release onwards.
fixes #4340