feat(ts): convert menu #4652
feat(ts): convert menu #4652
Conversation
- connectMenu - menu - menuSelect
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d9657c:
|
| let toggleShowMore = () => {}; | ||
| function createToggleShowMore( | ||
| renderOptions: RenderOptions, | ||
| widget: Widget |
There was a problem hiding this comment.
passing the "this" to this function is the most natural method I found for show more. refinementList and hierarchicalMenu aren't yet converted, so this is the first widget with this pattern
| menu: this.getWidgetRenderState(renderOptions), | ||
| menu: { | ||
| ...renderState.menu, | ||
| [attribute]: this.getWidgetRenderState(renderOptions), |
There was a problem hiding this comment.
note that this fixes a bug!
| // can not use = {} here, since the template could have different constraints | ||
| defaultTemplates?: TTemplates, |
There was a problem hiding this comment.
not super happy with this, but refinementList for example doesn't pass defaultTemplates at all
| menu: { | ||
| [attribute: string]: WidgetRenderState< | ||
| MenuRendererOptions, | ||
| MenuConnectorParams | ||
| >; | ||
| }; |
There was a problem hiding this comment.
same bugfix, as well as noting its omission in the type
| // @ts-ignore | ||
| menuSelect({ container: undefined }); |
There was a problem hiding this comment.
maybe we should bump the ts version so we can use ts-expect-error?
| const renderState1 = menu.getWidgetRenderState( | ||
| {}, | ||
| createInitOptions({ helper }) |
There was a problem hiding this comment.
this test was wrong :o
There was a problem hiding this comment.
good job by TS finding it out :)
| }); | ||
| } | ||
|
|
||
| if (!this._createURL) { | ||
| this._createURL = facetValue => | ||
| createURL(helper.state.toggleRefinement(attribute, facetValue)); |
There was a problem hiding this comment.
this function is deprecated, toggleFacetRefinement its exact replacement
Haroenv
requested review from
a team,
yannickcr and
eunjae-lee
and removed request for
a team
Summary
converts the menu-related files to typescript
Result
converted:
fixed a bug in connectMenu#getRenderState (forgotten to nest by attribute)