feat(queryRuleContext): allow to make refinements based on query #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this use case came up in a support ticket, they wanted to add a query rule when the query _did not_ match something. The engine only has positive matches, so negative matches need to be done frontend. Right now I implemented it like this: https://codesandbox.io/s/dynamically-deactivate-rule-forked-wouf8?file=/src/app.js but it would be nicer using trackedFilters as they should be used: (link pending)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 01135ec:
|
Haroenv
requested review from
francoischalifour,
a team and
eunjae-lee
and removed request for
a team
francoischalifour
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this use case came up in a support ticket, they wanted to add a query rule when the query did not match something. The engine only has positive matches, so negative matches need to be done frontend.
Result
Before that use case was implemented like this: https://codesandbox.io/s/dynamically-deactivate-rule-forked-wouf8?file=/src/app.js
With this PR it can be implemented like this: https://codesandbox.io/s/dynamically-deactivate-rule-forked-h9w20?file=/src/app.js
(still a bit longer than I wanted, but that's because you can't transform inside trackedFilters, and enabling it would be a breaking change)