fix(index): only set listeners on init once #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if init is called multiple times, multiple event listeners are attached, as well as the helper beign recreated. This fixes algolia/vue-instantsearch#911 by avoiding to have a different helper instance when init gets called multiple times
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ed1365:
|
Haroenv
commented
Jan 25, 2021
francoischalifour
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without this, if init is called multiple times (like in Vue InstantSearch), multiple event listeners are attached, as well as the helper being recreated. This causes the references from the first init call to no longer being correct later in the instance.
Since we save the references in the very first call of getWidgetRenderState in most widgets (
if (!refine) refine =), the helper reference needs to stay stable.Result
This fixes algolia/vue-instantsearch#911 by avoiding to have a different helper instance when init gets called multiple times.