feat(index): expose createURL #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for recreating what an index widget does when it renders, see ssr in Vue, as well as poc/telemetry2 I think in the future we might want a function to retrieve the parameters given to render / init.
ghost
requested review from
francoischalifour and
shortcuts
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 13383e4:
|
|
just realised the tests didn't get committed, let's add something now |
shortcuts
reviewed
Dec 18, 2020
| instance.init( | ||
| createInitOptions({ | ||
| instantSearchInstance: createInstantSearch({ | ||
| // @ts-ignore |
There was a problem hiding this comment.
Is it still needed as it's called at L679?
There was a problem hiding this comment.
yes, this function is meant to return a string, but an object is easier to assert on
This was referenced Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is useful for recreating what an index widget does when it renders, see ssr in Vue, as well as poc/telemetry2
I think in the future we might want a function to retrieve the parameters given to render / init.
Result
index exposes the scoped
createURLfunction to be used in render / init / getWidgetRenderState etc.