Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): implement getRenderState and getWidgetRenderState #4565

Merged
merged 8 commits into from
Nov 6, 2020
Merged

feat(stats): implement getRenderState and getWidgetRenderState #4565

merged 8 commits into from
Nov 6, 2020

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 3, 2020

This implements the getRenderState and getWidgetRenderState widget lifecycle hooks in stats.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 176400b:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small suggestions for the test left

src/connectors/stats/__tests__/connectStats-test.js Outdated Show resolved Hide resolved
src/connectors/stats/__tests__/connectStats-test.js Outdated Show resolved Hide resolved
src/connectors/stats/__tests__/connectStats-test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@shortcuts shortcuts merged commit bc1075c into algolia:feat/render-state Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants