fix(insights): show deprecation warnings for old insights related properties and functions #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properties and functions
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d3252f2:
|
eunjae-lee
commented
Sep 25, 2020
| @@ -15,6 +17,19 @@ function getCookie(name: string): string | undefined { | |||
| return undefined; | |||
| } | |||
|
|
|||
| export default function getInsightsAnonymousUserToken(): string | undefined { | |||
| export function getInsightsAnonymousUserTokenInternal(): string | undefined { | |||
There was a problem hiding this comment.
This logic is used internally by insights middleware. So we keep getInsightsAnonymousUserTokenInternal for us.
eunjae-lee
changed the title
eunjae-lee
changed the title
ghost
requested review from
francoischalifour and
yannickcr
and removed request for
a team
|
Did we make sure that the Insights middleware covers all cases that the |
Haroenv
reviewed
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates and shows warning messages for the following things:
getInsightsAnonymousUserToken()InstantSearch({ insightsClient })←insightsClientpropanalyticswidget