Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Use yarn workspaces #95

Closed
iam4x opened this issue Mar 5, 2018 · 4 comments
Closed

Use yarn workspaces #95

iam4x opened this issue Mar 5, 2018 · 4 comments

Comments

@iam4x
Copy link
Contributor

iam4x commented Mar 5, 2018

In order to resolve dependencies issues we should use yarn workspaces for building examples & documentation.

cc @vvo

@Haroenv
Copy link
Contributor

Haroenv commented Mar 5, 2018

This should be as simple as adding "workspaces": ["community-website", "src", "examples/*"], moving the main package into a subfolder (I called it src in this example), and putting private: true on the root package.json. You also need to remove the yarn.lock from all but the root after running yarn once :)

@iam4x
Copy link
Contributor Author

iam4x commented Mar 5, 2018

angular/angular-cli#7097

Angular CLI cannot resolve node_modules from a parent folder, this won't be doable for now. I will give it another try when Angular CLI v6 is out.

@iam4x iam4x closed this as completed Mar 5, 2018
@Haroenv
Copy link
Contributor

Haroenv commented Mar 5, 2018

You can use nohoist to fix this: https://yarnpkg.com/blog/2018/02/15/nohoist/

@iam4x
Copy link
Contributor Author

iam4x commented Mar 5, 2018

@Haroenv Yes sure, but there is no point to flag as nohoist all the examples dependencies since I wanted to have workspaces to share theses redundant dependencies :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants