Skip to content

Commit

Permalink
feat: support long in IncrementSet/IncrementFrom (#799)
Browse files Browse the repository at this point in the history
Co-authored-by: Hogne Vevle <[email protected]>
  • Loading branch information
sbellone and hognevevle committed Nov 5, 2021
1 parent cbafb8f commit 939f399
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 2 deletions.
32 changes: 30 additions & 2 deletions src/Algolia.Search.Test/Serializer/SerializerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ public void TestPartialUpdateOperation_Increment()

[Test]
[Parallelizable]
public void TestPartialUpdateOperation_IncrementFrom()
public void TestPartialUpdateOperation_IncrementFrom_int()
{
RecordWithPartialUpdateOperation<int> record = new RecordWithPartialUpdateOperation<int>
{
Expand All @@ -693,7 +693,21 @@ public void TestPartialUpdateOperation_IncrementFrom()

[Test]
[Parallelizable]
public void TestPartialUpdateOperation_IncrementSet()
public void TestPartialUpdateOperation_IncrementFrom_long()
{
RecordWithPartialUpdateOperation<long> record = new RecordWithPartialUpdateOperation<long>
{
ObjectID = "myID",
Update = PartialUpdateOperation<long>.IncrementFrom((long)2),
};

string json = JsonConvert.SerializeObject(record, JsonConfig.AlgoliaJsonSerializerSettings);
Assert.AreEqual(json, "{\"objectID\":\"myID\",\"update\":{\"_operation\":\"IncrementFrom\",\"value\":2}}");
}

[Test]
[Parallelizable]
public void TestPartialUpdateOperation_IncrementSet_int()
{
RecordWithPartialUpdateOperation<int> record = new RecordWithPartialUpdateOperation<int>
{
Expand All @@ -705,6 +719,20 @@ public void TestPartialUpdateOperation_IncrementSet()
Assert.AreEqual(json, "{\"objectID\":\"myID\",\"update\":{\"_operation\":\"IncrementSet\",\"value\":2}}");
}

[Test]
[Parallelizable]
public void TestPartialUpdateOperation_IncrementSet_long()
{
RecordWithPartialUpdateOperation<long> record = new RecordWithPartialUpdateOperation<long>
{
ObjectID = "myID",
Update = PartialUpdateOperation<long>.IncrementSet((long)2),
};

string json = JsonConvert.SerializeObject(record, JsonConfig.AlgoliaJsonSerializerSettings);
Assert.AreEqual(json, "{\"objectID\":\"myID\",\"update\":{\"_operation\":\"IncrementSet\",\"value\":2}}");
}

[Test]
[Parallelizable]
public void TestPartialUpdateOperation_Decrement()
Expand Down
20 changes: 20 additions & 0 deletions src/Algolia.Search/Models/Search/PartialUpdateOperation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ public static PartialUpdateOperation<int> IncrementFrom(int value)
};
}

///<inheritdoc cref="IncrementFrom(int)"/>
public static PartialUpdateOperation<long> IncrementFrom(long value)
{
return new PartialUpdateOperation<long>
{
Operation = PartialUpdateOperationType.IncrementFrom,
Value = value,
};
}

/// <summary>
/// Increment a numeric integer attribute only if the provided value is greater than the current value, and otherwise ignore the whole object update
/// </summary>
Expand All @@ -81,6 +91,16 @@ public static PartialUpdateOperation<int> IncrementSet(int value)
};
}

///<inheritdoc cref="IncrementSet(int)"/>
public static PartialUpdateOperation<long> IncrementSet(long value)
{
return new PartialUpdateOperation<long>
{
Operation = PartialUpdateOperationType.IncrementSet,
Value = value,
};
}

/// <summary>
/// Decrement by an integer value
/// </summary>
Expand Down

0 comments on commit 939f399

Please sign in to comment.