Feat/input legacy method fix #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 9, 2020 20:48
aso1datov
requested review from
SiebenSieben,
Heymdall,
Luchanso,
stepancar,
tx44,
bamaboy and
IBelyaev
SiebenSieben
approved these changes
Mar 3, 2020
Luchanso
approved these changes
Mar 3, 2020
bamaboy
reviewed
Mar 4, 2020
| @@ -262,6 +279,13 @@ export class Input extends React.PureComponent<InputProps> { | |||
| resetError: true | |||
| }; | |||
|
|
|||
| componentDidUpdate(prevProps: InputProps) { | |||
There was a problem hiding this comment.
А не думал заменить на getDerivedStateFromProps?
There was a problem hiding this comment.
Думал, но там трабл возникает, когда одно и то же поле меняется и из проспов и из стейта
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Мотивация и контекст
Изменение lifecycle в рамках задачи #911
Исправлено поведение поля ввода при фокусе в
CalendarInputаналогичноInput.