Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Document the cryptosystem used to encrypt notes in the database. #4

Open
virtadpt opened this issue Jun 6, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@virtadpt
Copy link

virtadpt commented Jun 6, 2020

As far as I can tell, Plainpad's app/Models/Note.php module uses Laravel's lluminate\Support\Facades\Crypt class. Some research suggests that the Crypt module implements AES-128 and AES-256, though I haven't found anything definitive about this, nor have I found the cipher mode that it implements (ECB (I hope not)? OFB? CBC?) It would be very helpful to know for sure what was used and how to come up with a threat model for Plainpad.

@alextselegidis alextselegidis self-assigned this Jun 18, 2020
@alextselegidis
Copy link
Owner

Hello @virtadpt

Where would you like to see this information being documented?

  Alex Tselegidis, Plainpad Creator
  Need a customization? Contact me in person!

@virtadpt
Copy link
Author

At https://alextselegidis.com/get/plainpad would be good, because that's the first place folks are likely to look (or google). A comment in the source code would also be helpful, because technical users are likely to go grepping through the files looking for hints as to what is used (as I did).

@alextselegidis alextselegidis added the documentation Improvements or additions to documentation label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants