Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Does not handle states based on immutable library. #10

Closed
leonaves opened this issue Feb 28, 2016 · 5 comments
Closed

Does not handle states based on immutable library. #10

leonaves opened this issue Feb 28, 2016 · 5 comments

Comments

@leonaves
Copy link
Contributor

As mentioned here: alexkuz/react-json-tree#32 immutable does not work correctly with this monitor due to a.) a bug in react-json-tree and b.) the fact that the jsondiff view does not consider immutable when generating deltas.

@ingro
Copy link

ingro commented Mar 1, 2016

Yep I'm experiencing this too.
A working approach may be this one from redux-devtools-diff-monitor which works quite well with Immutable data!

@alexkuz
Copy link
Owner

alexkuz commented Mar 2, 2016

I'm bothered that it affects performance significantly, if you have a huge array or object in your state. May be there should be an option in inspector that enables full Immutable support, I'm not sure.

@alexkuz
Copy link
Owner

alexkuz commented Mar 2, 2016

Also, I just found out - looks like Immutable doesn't support iterators with non-object entries (but maybe it's a valid behaviour, I don't know).

@ingro
Copy link

ingro commented Mar 2, 2016

Not sure about that, anyway an option could be a good compromise.

@alexkuz
Copy link
Owner

alexkuz commented Mar 2, 2016

Try this out:

default:
http://alexkuz.github.io/redux-devtools-inspector/

with immutable support in diff:
http://alexkuz.github.io/redux-devtools-inspector/?immutable

in the last example you'll notice performance issues after clicking "push huge array" several times.

@alexkuz alexkuz closed this as completed Mar 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants