Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Possible mistype #102

Open
ziflex opened this issue Jan 16, 2018 · 0 comments
Open

Possible mistype #102

ziflex opened this issue Jan 16, 2018 · 0 comments

Comments

@ziflex
Copy link

ziflex commented Jan 16, 2018

I have notice that valueRenderer receives a values twice as arg1 and arg2.

https://github.com/alexkuz/react-json-tree/blob/master/src/JSONValueNode.js#L22

Shouldn't nodeType be send as the 2nd arg?

<span {...styling('valueText', nodeType, keyPath)}>
  {valueRenderer(valueGetter(value), nodeType, ...keyPath)}
</span>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant