Skip to content

Commit

Permalink
rollup merge of rust-lang#18527 : bkoropoff/issue-18490
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcrichton committed Nov 3, 2014
2 parents 6f00bee + 107af28 commit bb7805f
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/librustc/middle/typeck/check/vtable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@ pub fn check_object_safety(tcx: &ty::ctxt, object_trait: &ty::TyTrait, span: Spa
receiver through a trait object", method_name))
}

ty::StaticExplicitSelfCategory |
ty::StaticExplicitSelfCategory => {
// Static methods are always object-safe since they
// can't be called through a trait object
return msgs
}
ty::ByReferenceExplicitSelfCategory(..) |
ty::ByBoxExplicitSelfCategory => {}
}
Expand Down
27 changes: 27 additions & 0 deletions src/test/run-pass/trait-object-safety.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Check that object-safe methods are identified as such. Also
// acts as a regression test for #18490

trait Tr {
// Static methods are always safe regardless of other rules
fn new() -> Self;
}

struct St;

impl Tr for St {
fn new() -> St { St }
}

fn main() {
&St as &Tr;
}

0 comments on commit bb7805f

Please sign in to comment.