-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use miniz_oxide directly in rust backend #202
Conversation
Thanks for this! One thing I'd like to do here is to reduce the number of |
I'll look into it. |
Right, pushed all of the back-end specific stuff into Is there some specific reason the zlib |
That's actually probably a bug, want to go ahead and box both of them up? I think there's also an error on nightly to handle? |
I'll box both then. The nightly error may actually be something that's in the original code, the lint was added recently, and the original code uses |
Hm yeah so I think I messed that up when I wrote libz-sys. If you wouldn't mind adding |
Ignore warning so build works on nightly while bug in libz is not fixed
👍 |
This avoids the C API and it's unsafeness entirely.
Can probably further simplify a bit by altering the Stream struct and direction trait StreamWrapper doesn't have to be an enum, neither are public.
Needs some thorough testing.
fixes #181