New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git author is the committer #14

Open

natestedman opened this issue Jan 6, 2011 · 0 comments

natestedman commented Jan 6, 2011

In git.py you're doing:

    return Commit(commit.id, commit.committer,
        datetime.fromtimestamp(commit.commit_time), commit.message, files,
        lambda: generate_unified_diff(self, files, parent, commit.id))

But this sets the author of the commit to the committer, which isn't always the case. It should be:

    return Commit(commit.id, commit.author,
        datetime.fromtimestamp(commit.commit_time), commit.message, files,
        lambda: generate_unified_diff(self, files, parent, commit.id))

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment