Add ONNX Model Export Support #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for pushing these! |
|
Conflict and syntax errors on python3.8 should be fixed. Also, support for the action mask was added in the ONNX export. EDIT: investigating test errors |
This reverts commit bc28dbc.
|
@alex-petrenko I think it's ready to get review |
fabioseel
pushed a commit
to fabioseel/sample-factory
that referenced
this pull request
Nov 21, 2024
* support onnx export * add doc for onnx export * fix for action_mask * fix TypeError on python 3.8 * install onnx on ci for mac * add debug info * Revert "add debug info" This reverts commit bc28dbc. * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for exporting trained models to the ONNX format in Sample Factory. The feature will be useful in many cases, including for people who want to use their trained models on a different platform or language. It's nice to build the functionality into Sample Factory, since usually, the underlying architecture is something that users don't need to know about.
It's implemented using TorchScript-based ONNX Exporter for now. I tried TorchDynamo as well but couldn’t get it to work.
The usage is described in the added documentation.