Skip to content

Commit c2b540c

Browse files
committed
Fix typing: Missing return types on methods
1 parent 07c34f9 commit c2b540c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/aleph/vm/hypervisors/firecracker/microvm.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,18 @@ def namespace_path(self) -> str:
104104
return str(self.jailer_base_directory / firecracker_bin_name / str(self.vm_id))
105105

106106
@property
107-
def jailer_path(self):
107+
def jailer_path(self) -> str:
108108
return os.path.join(self.namespace_path, "root")
109109

110110
@property
111-
def socket_path(self):
111+
def socket_path(self) -> str:
112112
if self.use_jailer:
113113
return f"{self.jailer_path}/run/firecracker.socket"
114114
else:
115115
return f"/tmp/firecracker-{self.vm_id}.socket"
116116

117117
@property
118-
def vsock_path(self):
118+
def vsock_path(self) -> str:
119119
if self.use_jailer:
120120
return f"{self.jailer_path}{VSOCK_PATH}"
121121
else:
@@ -140,17 +140,17 @@ def __init__(
140140
self.runtime_config = None
141141
self.log_queues: list[asyncio.Queue] = []
142142

143-
def to_dict(self):
143+
def to_dict(self) -> dict:
144144
return {
145145
"jailer_path": self.jailer_path,
146146
"socket_path": self.socket_path,
147147
"vsock_path": self.vsock_path,
148148
**self.__dict__,
149149
}
150150

151-
def prepare_jailer(self):
151+
def prepare_jailer(self) -> None:
152152
if not self.use_jailer:
153-
return False
153+
return
154154
system(f"rm -fr {self.jailer_path}")
155155

156156
# system(f"rm -fr {self.jailer_path}/run/")

0 commit comments

Comments
 (0)