feat: Changed to use watch for wait rollout #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehipwell
force-pushed
the
wait-rollout-watch
branch
from
5e25656 to
ea4b9ac
Compare
|
@alekc could you take a look at this? |
|
@stevehipwell could you rebase and fix conflicts please? |
stevehipwell
force-pushed
the
wait-rollout-watch
branch
2 times, most recently
from
f846741 to
8799c7d
Compare
|
@alekc I've rebased. I'm planning on doing the same changes for the |
stevehipwell
force-pushed
the
wait-rollout-watch
branch
from
8799c7d to
1181ece
Compare
|
Sure, I'll wait for that one and make a 4.1.0-beta2 release (so that all changes can be tested entirely by using terraform registry provider). |
|
@alekc could you give me a min, I've spotted a bug in the delete wait code which I'll fix in this PR. |
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
wait-rollout-watch
branch
from
1181ece to
785bbe7
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the logic for
wait_for_rolloutto use a watch and adds the missing functionality forDaemonSet&StatefulSetresources.