-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend wait_for with optional condition blocks #157
Extend wait_for with optional condition blocks #157
Conversation
Thanks for your contribution. I will review it as soon as possible 👍 |
0fab4d9
to
8cbcd6e
Compare
@jkabonickAtOlo sorry it took so long. I have just one minor remark, and then it should be good to go. |
internal/types/wait_for.go
Outdated
type WaitForStatusCondition struct { | ||
Type string | ||
Status string | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkabonickAtOlo you might want to fix this before it gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevehipwell I might be missing something, what is the problem with the struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing/removed EOF (shows up online but I'm not sure about mobile).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take care of that. Thank you for pointing it out.
b8a3674
to
bd2961d
Compare
@jkabonickAtOlo I think you're missing the README updates for this new functionality? |
Addresses #155.
wait_for
to also support waiting forstatus.Conditions
with acondition
block.Can be used as below, with or without the existing
field
block.