Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Avoid displaying the webview on every opened VS Code instance #10

Open
alefragnani opened this issue Dec 1, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alefragnani
Copy link
Owner

Today, when the “What’s New” window appears, it is shown on every VS Code instance.

The idea is that the “What’s New” window only be shown in one VS Code window (preferably the “active”). VS Code itself works this way.

@hyperupcall
Copy link

hyperupcall commented Jul 19, 2023

It may be worthwhile to take into account different Profiles as well:

bookmarks (copy)

I think the switching from one profile to another is still within the same VSCode instance, so it may be worth adding logic for this.

Currently after updating Bookmarks, I may have to close the "What's new" tabs popups quite a few times (up to 30ish as you can see), even if I read it the first time.

@alefragnani
Copy link
Owner Author

Hi @hyperupcall ,

The reason behind #42 is to deal with it. Profiles may use different versions of the same extension (until you update it) so, when you switch between profiles, the extension may think it has been downgraded and would fire the what's new window. With #42, this would not happen anymore, after every Profile to be updated to the version of the extension that does support that.

At first, I tried to identify the Profile to achieve that instead, but there is not API available, unfortunately.

Hope this helps

@hyperupcall
Copy link

I see - it is unfortunate there is no API available but I am glad that you considered the option. Thank you also for making the Bookmarks extension!

@alefragnani
Copy link
Owner Author

Let's hope it works as expected. And once this issue is also released, I expect the window to be displayed only once, when really expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants