Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup list filtering #3979

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Backup list filtering #3979

merged 5 commits into from
Aug 9, 2023

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Aug 7, 2023

Now that we store backup models for
backups that had errors filter them
out during backup list. This
ensures behavior doesn't change
when we merge PRs for making and
labeling backup models with the
assist backup tag

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Supportability/Tests
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn ashmrtn added the ux label Aug 7, 2023
@ashmrtn ashmrtn self-assigned this Aug 7, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 7, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:42 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:42 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:42 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:42 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 17:42 — with GitHub Actions Inactive
pandeyabs
pandeyabs approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@pandeyabs pandeyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ryanfkeepers
ryanfkeepers approved these changes Aug 7, 2023
View reviewed changes
src/pkg/repository/repository.go Outdated Show resolved Hide resolved
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:34 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing August 7, 2023 19:35 — with GitHub Actions Inactive
@ashmrtn
Filter out assist backups during backup list
c0ab929 
We haven't been showing incomplete backups in the past so continue that
behavior by filtering out assist (failed) backups.
@ashmrtn
Tests for filtering backups
81536ee
@ashmrtn
Minor comment update based on review
dceed25
@ashmrtn ashmrtn changed the base branch from partial_bup to main August 8, 2023 19:13
@ashmrtn ashmrtn temporarily deployed to Testing August 8, 2023 20:08 — with GitHub Actions Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 20:55 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 20:55 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Aug 8, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 8, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Test-Suite-Trusted

@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@ashmrtn ashmrtn removed the blocked Upstream item prevents completion label Aug 8, 2023
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 8, 2023 21:39 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Aug 8, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 8, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Test-Suite-Trusted

@ashmrtn ashmrtn removed the blocked Upstream item prevents completion label Aug 9, 2023
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:18 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:18 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:19 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing August 9, 2023 00:19 Inactive
@aviator-app aviator-app bot merged commit 9ec638f into main Aug 9, 2023
22 checks passed
@aviator-app aviator-app bot deleted the 3973-backup-filtering branch August 9, 2023 00:53
@ashmrtn ashmrtn mentioned this pull request Aug 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandeyabs pandeyabs pandeyabs approved these changes

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@ashmrtn ashmrtn

Labels
mergequeue ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmrtn @pandeyabs @ryanfkeepers