add basic groups boilerplate #3971
Conversation
Current Aviator status
This PR was merged using Aviator. |
src/pkg/backup/details/details.go
Outdated
| @@ -1025,6 +1026,50 @@ func (i *OneDriveInfo) updateFolder(f *FolderInfo) error { | |||
| return updateFolderWithinDrive(OneDriveItem, i.DriveName, i.DriveID, f) | |||
| } | |||
|
|
|||
| // GroupsInfo describes a groups item | |||
| type GroupsInfo struct { | |||
There was a problem hiding this comment.
I feel like it should be singular Group instead of Groups as others are singular, for example OneDriveInfo and ExchangeInfo.
There was a problem hiding this comment.
I'm waffling on that. Groups (and similarly, Teams) with the plural is the formal name of the service. Unlike the others, which are formally named by their singular. Let's talk this over briefly in the meeting tomorrow to see if there are strong feelings either way, yeah?
src/pkg/backup/details/details.go
Outdated
| return nil, clues.New("not yet implemented") | ||
| } | ||
|
|
||
| func (i *GroupsInfo) updateFolder(f *FolderInfo) error { |
There was a problem hiding this comment.
We can maybe add it to updateFolder. Same for uniqueLocation.
There was a problem hiding this comment.
I think I got this in a follow-up PR.
backup/details has gotten to large to navigate. This change splits up the file into multiple files based on structure.
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Source-Code-Linting |
|
Kudos, SonarCloud Quality Gate passed!
|
Adding in some basic boilerplate for groups service.
Does this PR need a docs update or release note?
Type of change