Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::binary_function is deprecated since c++11 #73

Open
tari opened this issue Sep 11, 2023 · 0 comments · May be fixed by #75
Open

std::binary_function is deprecated since c++11 #73

tari opened this issue Sep 11, 2023 · 0 comments · May be fixed by #75

Comments

@tari
Copy link
Contributor

tari commented Sep 11, 2023

hash.h uses std::binary_function on the string comparator function, which is an error when built as c++17 or newer because std::binary_function was removed in c++17 (after being deprecated in c++11).

With c++11 or newer, simply removing the use of std::binary_function is fine. Either builds with newer compilers that default to new language versions (GCC 11 or newer, Clang 16 or newer) need to explicitly use c++11 mode, or hash.h needs to be patched to remove use of binary_function.

tari added a commit to tari/spasm-ng that referenced this issue Sep 18, 2023
This is unneeded after c++11, and broken from c++17.

Fixes alberthdev#73
tari added a commit to tari/spasm-ng that referenced this issue Sep 18, 2023
This is unneeded after c++11, and broken from c++17.

Fixes alberthdev#73
tari added a commit to tari/spasm-ng that referenced this issue Sep 18, 2023
This is unneeded after c++11, and broken from c++17.

Fixes alberthdev#73
@tari tari linked a pull request Sep 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant