Skip to content

OSDSUS and OSDUpdate modules should not be required before importing the WimWitchFK module #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
technomancer-101 opened this issue Feb 27, 2024 · 0 comments

Comments

@technomancer-101
Copy link

Expected Behavior

When importing the new WimWitchFK module on a computer for the first time, it should load and then detect if OSDSUS and OSDUpdate are installed. If they are not, WimWitch will prompt to install NuGet and then use that to install OSDSUS and OSDUpdate.

Current Behavior

With the new module, both OSDSUS and OSDUpdate are marked as required modules in both the manifest files and main PS script, so if they are not installed ahead of time, the module will fail to import.

Possible Solution

Removing the module requirements for OSDSUS and OSDUpdate from both scripts allows the module to import and run normally, at which point it detects they are missing and will install them automatically.

Steps to Reproduce (for bugs)

  1. Attempt to import the new module on any computer that has not previously had OSDSUS or OSDUpdate installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant