Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Broken URLs and missing DOI in Notebook ROs #122

Closed
10 tasks done
Tracked by #126
acocac opened this issue Oct 27, 2022 · 5 comments
Closed
10 tasks done
Tracked by #126

[BUG] Broken URLs and missing DOI in Notebook ROs #122

acocac opened this issue Oct 27, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@acocac
Copy link
Member

acocac commented Oct 27, 2022

Describe the bug

Research objects of listed notebooks below are pointing to old URLs.

  • Detecting floating objects using deep learning and Sentinel-2 imagery
  • Met Office UKV high-resolution atmosphere model data
  • MODIS MOD021KM and FIRMS
  • Tree crown detection using DeepForest
  • SEVIRI Level 1.5
  • Tree crown delineation using detectreeRGB
  • Sea ice forecasting using IceNet
  • Cosmos-UK soil moisture
  • Concatenating a gridded rainfall reanalysis dataset into a time series
  • Exploring Land Cover Data (Impact Observatory)

How To Reproduce

  1. Go to RoHub
  2. Open URLs in the tool folder
  3. Broken website

Expected behaviour

Open a working URL

Environment (generate for Linux, macOS and 64-bit Windows)

N/A. Browser.

Additional information

Additional checks include:

  • Set main entity as Jupyter Notebook
  • Set publisher and copyright to EDS book community
  • Associate a community, in this case EDS book community
  • Approximate to 100% completeness
  • Assign a DOI (snapshop) using Zenodo
@acocac acocac added the bug Something isn't working label Oct 27, 2022
@acocac acocac self-assigned this Oct 27, 2022
@acocac acocac changed the title [BUG] Update URLs in RoHub [BUG] Validate URLs and assign DOI to Notebook ROs Oct 28, 2022
@acocac acocac changed the title [BUG] Validate URLs and assign DOI to Notebook ROs [BUG] Broken URLs and missing DOI in Notebook ROs Oct 28, 2022
@acocac
Copy link
Member Author

acocac commented Apr 16, 2023

All notebooks have working URLs and additional checks ok, except completeness.

@camappel
Copy link

camappel commented Aug 6, 2024

Are the notebook repository urls still up-to-date? For instance, the raw files for the DeepForest notebook returns a 400 error. Likewise, the EDS gallery only contains the .ipynb, not the lock files (as stated here).

I set up the environment manually, but I believe this is resulting in the xarray package not loading correctly.

@acocac
Copy link
Member Author

acocac commented Aug 7, 2024

@camappel - thanks for reporting the issue. I've opened a new issue to address it.

The notebook repository contains a single conda lock file which is compatible with the version 2.x of conda-lock. The documentation in the "How to use EDS book notebooks" section uses an older version of conda-lock which creates a separate file per operating system. I hope this makes sense.

@camappel
Copy link

camappel commented Aug 8, 2024

Got it, thanks - I'll try to recreate the environment using the single lock file.

@acocac
Copy link
Member Author

acocac commented Aug 9, 2024

Got it, thanks - I'll try to recreate the environment using the single lock file.

Cool - Please feel free to open new issues if you have any while using the single lock file or any other process exploring the gallery of EDS book notebooks. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants