Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isort to pre-commit #94

Closed
mastoffel opened this issue Dec 19, 2023 · 9 comments
Closed

add isort to pre-commit #94

mastoffel opened this issue Dec 19, 2023 · 9 comments
Assignees
@kallewesterling @mastoffel

Comments

@mastoffel
Copy link
Collaborator

sorting imports with isort, thanks to @bryanlimy for the suggestion.
@mastoffel mastoffel self-assigned this Dec 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Product backlog in AutoEmulate Dec 20, 2023
@kallewesterling
Copy link
Collaborator

Looks pretty easy to implement - want me to have a quick go, @mastoffel?

@mastoffel
Copy link
Collaborator Author

mastoffel commented Jan 16, 2024 •
edited
Loading

Yes, please! (also: no need to ask).

@kallewesterling
Copy link
Collaborator

Turns out it wasn't as easy as they made it look! Not giving up yet though!

@mastoffel
Copy link
Collaborator Author

ah, it never is! Don't worry too much if it doesn't work @kallewesterling!

@mastoffel
Copy link
Collaborator Author

@all-contributors please add @kallewesterling for doc, code, content

@allcontributors allcontributors bot mentioned this issue Jan 17, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@mastoffel

I've put up a pull request to add @kallewesterling! 🎉

@mastoffel
Copy link
Collaborator Author

forgot: @all-contributors add projectManagement for @kallewesterling

@allcontributors allcontributors bot mentioned this issue Jan 17, 2024
Closed
@allcontributors AllContributors
Copy link
Contributor

@mastoffel

I've put up a pull request to add @ProjectManagement! 🎉

@mastoffel
Copy link
Collaborator Author

sorting pre-commit implemented by @kallewesterling in #114 , using reorder-python-imports as poetry made problems with isort.

@github-project-automation github-project-automation bot moved this from 📋 Product backlog to ✅ Done in AutoEmulate Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kallewesterling kallewesterling

@mastoffel mastoffel

Labels
None yet
Projects
AutoEmulate
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kallewesterling @mastoffel