Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllerInstanceID does not create Analysisrun in the controller cluster #3185

Open
liron-smarsh opened this issue Dec 22, 2024 · 0 comments

Comments

@liron-smarsh
Copy link

liron-smarsh commented Dec 22, 2024

Checklist

  • [ * ] I've searched the issue queue to verify this is not a duplicate bug report.
  • [ * ] I've included steps to reproduce the bug.
  • [ * ] I've pasted the output of kargo version.
  • [ * ] I've pasted logs, if applicable.

Description

When specifying controller.rollouts.controllerInstanceID in the Kargo helm chart the label argo-rollouts.argoproj.io/controller-instance-id is added to the Analysisrun but the the Analysisrun is created on the control plane cluster and not in the controller cluster as stated
https://github.com/akuity/kargo/tree/main/charts/kargo in the doc
"Specifies a cluster on which Jobs corresponding to an AnalysisRun (used for Freight/Stage verification purposes) will be executed. "
and #1706
"Note: This doesn't mean AnalysisRuns cannot execute elsewhere now. That continues to be achievable by setting controller.rollouts.controllerInstanceID on a Kargo controller."

Steps to Reproduce

Install Kargo control plane in cluster 1, install Kargo controller in cluster2, set kubeconfig for both Kargo & Argocd, set controller.rollouts.controllerInstanceID values to some id on cluster2 and watch the Analysisrun created on the control plane cluster (cluster1).
expected result, Analysisrun will be created on cluster2
(note: It doesn't matter if the controller is sharded or not, I get the same result)

Version

1.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant