-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(ui): stage phase icon + tooltip missing for some phases #2776
Comments
@krancour thats Stage health status icon. Ok this UI code was a year ago and I think there was not "phase" initially? Or maybe health and phase had some correlation? Anyways this needs to be changed if thats the case. |
@Marvin9 you're right. I have my wires crossed here. That icon is for health, and not for phase, as you correctly point out. Health can legitimately be nil, especially for a brand new Stage that has not had any Promotions yet (or hasn't had any successful Promotions yet). I wonder if nil health is the source of this. |
Yes nil health is the issue. But I think we should show both.. stage health + stage phase right? |
I believe UI can use new analogy after #2905? |
In this particular case, the Stage was in the new (as of #2762)
Failed
phase, so the UI not being prepared for that wasn't surprising, but I believe I've seen this occur many times prior to #2762. (I have a hunch that no phase (""
), which is possible for a brand new Stage, may be unaccounted for.)The text was updated successfully, but these errors were encountered: