Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make promoter info (username and email, at least) available in expressions #3081

Open
Sebast1aan opened this issue Dec 6, 2024 · 6 comments

Comments

@Sebast1aan
Copy link
Contributor

Checklist

  • [ X] I've searched the issue queue to verify this is not a duplicate feature request.
  • [ X] I've pasted the output of kargo version, if applicable.
  • [ X] I've pasted logs, if applicable.

Proposed Feature

When currently using the git-commit promotion step, the commits are done with the default user kargo (if no explicit author.name is set). If a promotion is done manually, it would be useful that this becomes kargo-$logged-in-user (such as kargo-admin, in case you log in with the admin account). In the promotion history you can already see who initiated the promotion, but in the git commit log itself there is no trace of it.

Motivation

This would enable to easily see who initiated a git commit from within kargo.

@krancour
Copy link
Member

krancour commented Dec 9, 2024

I think the most sensible thing here might be to make promoter information available within expressions, so you can dynamically populate the existing author info fields.

@krancour krancour changed the title git-commit: include promotor username into git commit author make promoter info (username and email, at least) available in expressions Dec 9, 2024
@krancour krancour self-assigned this Dec 9, 2024
@creeram
Copy link

creeram commented Jan 2, 2025

@Sebast1aan Do you have any updates on when this feature might be implemented?

@krancour
Copy link
Member

krancour commented Jan 2, 2025

@creeram I believe @Sebast1aan was making a feature request and not necessarily volunteering to implement the feature. This is assigned to myself, but isn't currently regarded as a priority.

@creeram
Copy link

creeram commented Jan 2, 2025

@krancour I'm waiting for this feature to be implemented so I can use it in my configuration. This will allow us to get details in Slack about who performed the release and in which environment. I would appreciate it if you could start working on this.

@krancour
Copy link
Member

krancour commented Jan 2, 2025

@creeram our priorities aren't dictated by your needs. If you need this so urgently, you can take a crack at implementing it. Would you like me to assign it to you?

@creeram
Copy link

creeram commented Jan 2, 2025

@krancour Thank you for your response. I completely understand that open-source projects have their own priorities. However, I’d like to mention that not all users are developers or have the skills to contribute code. I appreciate the work you do and just wanted to share that a little understanding in responses can go a long way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants