Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stages should support referencing of ClusterAnalysisTemplates #2481

Open
jessesuen opened this issue Aug 29, 2024 · 2 comments · May be fixed by #2673
Open

Stages should support referencing of ClusterAnalysisTemplates #2481

jessesuen opened this issue Aug 29, 2024 · 2 comments · May be fixed by #2673
Assignees
@BenHesketh21
Labels
area/api area/controller area/crds area/ui kind/enhancement priority/normal size/x-large
Milestone
v1.3.0

Comments

@jessesuen
Copy link
Member

jessesuen commented Aug 29, 2024 •
edited
Loading

Proposed Feature

Today we support project (namespace) scoped AnalysisTemplates, but Argo Rollouts also has ClusterAnalysisTemplates. Currently, Kargo Stages can't reference them.

It's been requested that Stages have the ability to reference a globally defined ClusterAnalysisTemplate so that a change to the ClusterAnalysisTemplate can affect all Stages immediately.

Motivation

A Kargo operator wishes to centrally manage some verification checks that apply to all projects/stages and are not application specific.

Suggested Implementation

Introduce clusterScope: true to the template reference (matches argo-rollouts syntax)

  verification:
    analysisTemplates:
    - name: cat-fact
      clusterScope: true

NOTE: there would need to be a new UI component for this as well, since ClusterAnalysisTemplate would be managed outside of a single project.
@BenHesketh21
Copy link
Contributor

BenHesketh21 commented Sep 29, 2024 •
edited
Loading

I'd be interested in doing this, I've been wanting to take a look at another issue but not wanted to take anything that's needed quickly for the v0.9.0 release since I know you are working hard to get that out.

@krancour
Copy link
Member

@BenHesketh21 it's all yours. We appreciate it!

@krancour krancour added this to the Post-GA milestone Sep 30, 2024
@BenHesketh21 BenHesketh21 linked a pull request Oct 6, 2024 that will close this issue
Open
@krancour krancour modified the milestones: Post-GA, v1.1.0 Nov 7, 2024
@krancour krancour modified the milestones: v1.1.0, v1.2.0 Nov 15, 2024
@krancour krancour modified the milestones: v1.2.0, v1.3.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHesketh21 BenHesketh21

Labels
area/api area/controller area/crds area/ui kind/enhancement priority/normal size/x-large
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

feat: Adding ClusterAnalysisTemplate support for Stage verifications BenHesketh21/kargo
3 participants
@krancour @jessesuen @BenHesketh21