Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release as an executable #31

Open
timkicker opened this issue May 18, 2022 · 2 comments
Open

Release as an executable #31

timkicker opened this issue May 18, 2022 · 2 comments

Comments

@timkicker
Copy link

Maybe consider releasing an executable like appimage or flatpack.

@aknobloch
Copy link
Owner

Hey, thanks for the interest! My main concern with building a release file is the necessary inclusion of proprietary codecs. There's a section in the README which touches on this point. Without proprietary codecs, the app functionality is pretty limited. I'm not a lawyer, but my understanding is that I could get myself into some legal trouble if I build a distributable binary which includes proprietary codecs. I believe other OSS, such as Firefox, runs into this same problem.

I would legitimately love to hear if I'm mistaken, though. So if you think otherwise, please let me know!

@aknobloch
Copy link
Owner

Although, I'm also open to releasing a limited version that doesn't include these. It's been a while since I poked around at this project, so will have to revisit the behavior when these aren't included. IIRC, Plex itself starts throwing some generic errors on some codecs, and on others I was seeing a crash. This was a while back, though, so my memory is fuzzy. I'll try to take a look myself, but if you know the behavior that would help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants