Skip to content

[xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2#8129

Merged
Aaronontheweb merged 4 commits into
akkadotnet:devfrom
Arkatufus:xunit3/Fix-Akka.Remote.TestKit
Mar 24, 2026
Merged

[xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2#8129
Aaronontheweb merged 4 commits into
akkadotnet:devfrom
Arkatufus:xunit3/Fix-Akka.Remote.TestKit

Conversation

@Arkatufus

Copy link
Copy Markdown
Contributor

Changes

Akka.Remote.TestKit.Xunit2 was using the wrong resource path to load its default HOCON config, causing exception during initialization.

@Arkatufus Arkatufus left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

public static Config Default()
{
return FromResource("Akka.Remote.TestKit.Internals.Reference.conf");
return FromResource($"{typeof(AssemblyLocator).Assembly.GetName().Name}.Internals.Reference.conf");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix, do not use hard coded assembly name, determine it during runtime instead.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class is now shared between Akka.Remote.TestKit and Akka.Remote.TestKit.Xunit2

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) March 24, 2026 16:38

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit ed2c263 into akkadotnet:dev Mar 24, 2026
12 checks passed
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Mar 27, 2026
* [xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2
* Update API Approval list
* Add local only test project for Akka.Remote.TestKit.Xunit2

(cherry picked from commit ed2c263)
Aaronontheweb pushed a commit that referenced this pull request Mar 30, 2026
* Merge MNTR back to core (#8133)

* initial commit
* Refactor all multinode projects to use the in repo project
* Update slopwatch baseline list
* resync xunit version for Akka.MultiNode.TestAdapter
* Fix project build targets
* Revert "Fix project build targets" This reverts commit 71ee93c.
* Exclude TestAdapter.Tests from running in net framework tests in CI/CD
* Enable test discovery error reporting

(cherry picked from commit 152eb10)

* Post-cherry pick fix

* Rerun CI/CD

* [xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2 (#8129)

* [xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2
* Update API Approval list
* Add local only test project for Akka.Remote.TestKit.Xunit2

(cherry picked from commit ed2c263)

* Update API approval list
Aaronontheweb pushed a commit that referenced this pull request Apr 24, 2026
* [xUnit 3] Fix broken Akka.Remote.TestKit.Xunit2

* Update API Approval list

* Add local only test project for Akka.Remote.TestKit.Xunit2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants