Skip to content

Fix TcpListener to not stop from accepting further connections on transient accept errors #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 5 commits into from
Jan 7, 2026
Merged

Fix TcpListener to not stop from accepting further connections on transient accept errors #7970

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33bf6fd
Minimal fix to handle SocketError.ConnectionAborted in TcpListener.
petrikero Dec 22, 2025
0b603c4
Handle more transient error cases. Handle known fatal errors explicitly.
petrikero Dec 22, 2025
d7ab35a
Join code paths for known and unknown fatal errors.
petrikero Dec 23, 2025
09bd78d
Merge branch 'dev' into tcp-listener-fix
Aaronontheweb Dec 23, 2025
67aca8d
Merge branch 'dev' into tcp-listener-fix
Aaronontheweb Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/core/Akka/IO/TcpListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private bool HandleStatsMessages(object msg)
{
subscriber.Tell(stats);
}
}
}
return true;

case Tcp.SubscribeToTcpListenerStats subscribe:
Expand Down Expand Up @@ -277,10 +277,17 @@ private void HandleAccept(SocketAsyncEventArgs saea)
break;

case SocketError.ConnectionReset:
case SocketError.ConnectionAborted:

@Aaronontheweb Aaronontheweb Dec 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

case SocketError.NoBufferSpaceAvailable:
case SocketError.TryAgain:
case SocketError.TimedOut:
case SocketError.WouldBlock:
case SocketError.Interrupted:
case SocketError.TooManyOpenSockets:
case SocketError.NetworkUnreachable:
case SocketError.HostDown:
case SocketError.HostUnreachable:
case SocketError.ConnectionRefused:
_retryCount++;
_log.Warning("Retriable socket error in TcpListener: {0} - retrying accept operation in 10ms",
saea.SocketError);
Expand All @@ -289,9 +296,11 @@ private void HandleAccept(SocketAsyncEventArgs saea)
Context.System.Scheduler.ScheduleTellOnce(TimeSpan.FromMilliseconds(10), Self,
new RetryAccept(saea), ActorRefs.NoSender);
break;

// Fatal errors - the listener socket itself is broken
Comment thread
Aaronontheweb marked this conversation as resolved.
default:
_failedCount++;
_log.Error("Fatal socket error in TcpListener: {0}", saea.SocketError);
_log.Error("Fatal socket error in TcpListener: {0} - stopping listener", saea.SocketError);
Context.Stop(Self);
break;
}
Expand Down
Loading