Skip to content

Fix EventSourced Stash filtering out identical envelopes#7375

Merged
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Arkatufus:#7373-fix-persistence-stash
Nov 1, 2024
Merged

Fix EventSourced Stash filtering out identical envelopes#7375
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Arkatufus:#7373-fix-persistence-stash

Conversation

@Arkatufus

Copy link
Copy Markdown
Contributor

Fixes #7373

Changes

Removed the Distinct() filter

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll merge this in and then re-run #7374

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 1, 2024 12:39
@Aaronontheweb Aaronontheweb merged commit 67fad90 into akkadotnet:dev Nov 1, 2024
@to11mtm

to11mtm commented Nov 2, 2024

Copy link
Copy Markdown
Member

Ooops I did mean to leave one comment on this...

The behavior is semantically correct, should note it may or may not lead to 'vexing' behaviors for consumers that are inadvertently dependent on the behavior (e.x. repeated externally fired messages and they don't have proper guarding.

tl;dr- Good mention in release notes would be nice, I know I've had to write code to get around this in the past. <3

@Aaronontheweb

Copy link
Copy Markdown
Member

Ooops I did mean to leave one comment on this...

The behavior is semantically correct, should note it may or may not lead to 'vexing' behaviors for consumers that are inadvertently dependent on the behavior (e.x. repeated externally fired messages and they don't have proper guarding.

tl;dr- Good mention in release notes would be nice, I know I've had to write code to get around this in the past. <3

We'll try to address this on the front-end with akkadotnet/akka.analyzers#104 - but yes, we'll also add an upgrade advisory for this issue in v1.5.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Akka.Persistence: IStash filters out messages with identical senders + references

3 participants