From 802e34ec8cebfe33bae9f348562982733c5f3799 Mon Sep 17 00:00:00 2001 From: Aaron Stannard Date: Mon, 6 Sep 2021 12:16:01 -0500 Subject: [PATCH] disabled Akka.Persistence.TCK.Query.ReadJournal_should_deallocate_AllPersistenceIds_publisher_when_the_last_subscriber_left Not a good test - tightly couples to private implementation details for a given journal, plus it's racy. Better to test the stream stage it uses directly or use Akka.Streams completion semantics to check. --- src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs b/src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs index 47b82f41f06..0a16b1099a8 100644 --- a/src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs +++ b/src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs @@ -177,7 +177,7 @@ public virtual void ReadJournal_AllPersistenceIds_should_deliver_persistenceId_o }); } - [Fact] + [Fact(Skip = "Not a good test - tightly couples to private implementation details")] public virtual async Task ReadJournal_should_deallocate_AllPersistenceIds_publisher_when_the_last_subscriber_left() { if (AllocatesAllPersistenceIDsPublisher)