Make AWS ECS Service discovery mechanism public and non-sealed (#3366)#3375
Merged
Aaronontheweb merged 1 commit intoJul 18, 2025
Conversation
…t it can be overriden akkadotnet#3366
29d76d7 to
8e69184
Compare
Aaronontheweb
approved these changes
Jul 18, 2025
Aaronontheweb
left a comment
Member
There was a problem hiding this comment.
LGTM - trivial change and the reasoning is sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3366
Changes
Opens the
EcsServiceDiscoveryclass to extension by making it public and non-sealed. This will allow consumers of the library to override it and provide custom implementations.For example, out of the box, the library supports discovering "neighboring" nodes only from containers running in the same ECS Service. But as described in #3366, "neighboring" nodes may have to be discovered from multiple ECS Services that are part of an ECS Cluster. With this change, consumers of the library can use the decorator pattern to extend and modify the default behavior of the
EcsServiceDiscoveryclass.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
No impact on performance as a result of this PR.