Skip to content

Make AWS ECS Service discovery mechanism public and non-sealed (#3366)#3375

Merged
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
sbenedict-redblack:ecs-service-discovery-public-3366
Jul 18, 2025
Merged

Make AWS ECS Service discovery mechanism public and non-sealed (#3366)#3375
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
sbenedict-redblack:ecs-service-discovery-public-3366

Conversation

@sbenedict-redblack

@sbenedict-redblack sbenedict-redblack commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Fixes #3366

Changes

Opens the EcsServiceDiscovery class to extension by making it public and non-sealed. This will allow consumers of the library to override it and provide custom implementations.

For example, out of the box, the library supports discovering "neighboring" nodes only from containers running in the same ECS Service. But as described in #3366, "neighboring" nodes may have to be discovered from multiple ECS Services that are part of an ECS Cluster. With this change, consumers of the library can use the decorator pattern to extend and modify the default behavior of the EcsServiceDiscovery class.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

No impact on performance as a result of this PR.

@sbenedict-redblack sbenedict-redblack force-pushed the ecs-service-discovery-public-3366 branch from 29d76d7 to 8e69184 Compare July 18, 2025 05:54

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - trivial change and the reasoning is sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS ECS Discovery - Allow discovering "neighboring" nodes from multiple ECS Services

2 participants