Skip to content

Refactor AkkaDiscoveryOptions to AzureDiscoveryOptions #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Jun 17, 2025
Merged

Refactor AkkaDiscoveryOptions to AzureDiscoveryOptions #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/discovery/azure/Akka.Discovery.Azure.Tests/HostingSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public async Task WithAzureDiscoveryTest(
}),
(conn, builder) =>
{
var setup = new AkkaDiscoveryOptions
var setup = new AzureDiscoveryOptions
{
ConnectionString = conn,
ServiceName = "testService",
Expand Down
14 changes: 7 additions & 7 deletions src/discovery/azure/Akka.Discovery.Azure/AkkaHostingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
bool? readOnly = null,
bool isDefaultPlugin = true)
{
var options = new AkkaDiscoveryOptions
var options = new AzureDiscoveryOptions
{
IsDefaultPlugin = isDefaultPlugin,
ConfigPath = discoveryId,
Expand Down Expand Up @@ -154,7 +154,7 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
bool isDefaultPlugin = true)
{
if (azureCredential == null) throw new ArgumentNullException(nameof(azureCredential));
var options = new AkkaDiscoveryOptions
var options = new AzureDiscoveryOptions
{
IsDefaultPlugin = isDefaultPlugin,
ConfigPath = discoveryId,
Expand All @@ -178,7 +178,7 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
/// The builder instance being configured.
/// </param>
/// <param name="configure">
/// An action that modifies an <see cref="AkkaDiscoveryOptions"/> instance, used
/// An action that modifies an <see cref="AzureDiscoveryOptions"/> instance, used
/// to configure Akka.Discovery.Azure.
/// </param>
/// <returns>
Expand All @@ -200,9 +200,9 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
/// </example>
public static AkkaConfigurationBuilder WithAzureDiscovery(
this AkkaConfigurationBuilder builder,
Action<AkkaDiscoveryOptions> configure)
Action<AzureDiscoveryOptions> configure)
{
var setup = new AkkaDiscoveryOptions();
var setup = new AzureDiscoveryOptions();
configure(setup);
return builder.WithAzureDiscovery(setup);
}
Expand All @@ -216,7 +216,7 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
/// The builder instance being configured.
/// </param>
/// <param name="options">
/// The <see cref="AkkaDiscoveryOptions"/> instance used to configure Akka.Discovery.Azure.
/// The <see cref="AzureDiscoveryOptions"/> instance used to configure Akka.Discovery.Azure.
/// </param>
/// <returns>
/// The same <see cref="AkkaConfigurationBuilder"/> instance originally passed in.
Expand All @@ -237,7 +237,7 @@ public static AkkaConfigurationBuilder WithAzureDiscovery(
/// </example>
public static AkkaConfigurationBuilder WithAzureDiscovery(
this AkkaConfigurationBuilder builder,
AkkaDiscoveryOptions options)
AzureDiscoveryOptions options)
{
options.Apply(builder);

Expand Down
5 changes: 4 additions & 1 deletion ...a.Discovery.Azure/AkkaDiscoveryOptions.cs → ....Discovery.Azure/AzureDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@

namespace Akka.Discovery.Azure;

public class AkkaDiscoveryOptions: IDiscoveryOptions
[Obsolete("Class name typo, use AzureDiscoveryOptions class instead. Since 1.5.44, will be removed in v1.6")]
public class AkkaDiscoveryOptions : AzureDiscoveryOptions;

public class AzureDiscoveryOptions: IDiscoveryOptions
{

public string ConfigPath { get; set; } = "azure";
Expand Down