Skip to content

fix AzureDiscoveryGuardian child actors created incorrectly#3019

Merged
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Aaronontheweb:azure-discovery-fix-actors
Dec 24, 2024
Merged

fix AzureDiscoveryGuardian child actors created incorrectly#3019
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Aaronontheweb:azure-discovery-fix-actors

Conversation

@Aaronontheweb

@Aaronontheweb Aaronontheweb commented Dec 24, 2024

Copy link
Copy Markdown
Member

Changes

The AzureDiscoveryGuardian was creating all of its children as /user top-level actors, rather than as actual children under the /system hierarchy. This caused them to appear in tracing and for these actors to leak when the discovery plugin restarted or shut itself down.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were supposed to be children based on the shutdown code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant