Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/Akka.Hosting.Tests/RequiredActorSpecs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,37 @@ public async Task ShouldNotCacheNobodyAfterWhenWaitedForRegistration()
// assert
cachedActorRef.Should().NotBeOfType<Nobody>();
}

[Fact]
public async Task ShouldNotCacheNobodyBeforeRegistrationWithSyncActorRef()
{
// arrange
using var host = new HostBuilder()
.ConfigureServices(services =>
{
services.AddAkka("MySys", (builder, _) =>
{
builder.WithActors((system, registry) =>
{
var actor = system.ActorOf(Props.Create(() => new MyActorType()), "myactor");
registry.Register<MyActorType>(actor);
});
});
})
.Build();

var myRequiredActor = host.Services.GetRequiredService<IRequiredActor<MyActorType>>();

Action shouldThrow = () => _ = myRequiredActor.ActorRef;

shouldThrow.Should().Throw<MissingActorRegistryEntryException>();

await host.StartAsync();

// act
var cachedActorRef = await myRequiredActor.GetAsync();

// assert
cachedActorRef.Should().NotBeOfType<Nobody>();
}
}
4 changes: 2 additions & 2 deletions src/Akka.Hosting/ActorRegistry.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ public IActorRef ActorRef
return _internalRef;

// attempt 2 - synchronously check the registry (fast path)
if (_registry.TryGet<TActor>(out _internalRef))
if (_registry.TryGet<TActor>(out var internalRef))
{
return _internalRef;
return _internalRef = internalRef;
}


Expand Down