WithDistributedData() will start DistributedDataProvider extension automatically.#597
Conversation
…n automatically.
| { | ||
| options.Apply(builder); | ||
| builder.AddHocon(DistributedData.DistributedData.DefaultConfig(), HoconAddMode.Append); | ||
| builder.WithExtension<DistributedDataProvider>(); |
There was a problem hiding this comment.
Actual fix, add the extension to the auto-start list.
| var settings = ReplicatorSettings.Create(Sys); | ||
| var coordinatorName = settings.RestartReplicatorOnFailure ? $"{ReplicatorName}Supervisor" : ReplicatorName; | ||
|
|
||
| var actorSelection = Sys.ActorSelection(new RootActorPath(cluster.SelfAddress) / "user" / coordinatorName); |
There was a problem hiding this comment.
The replicator is started under user guardian, is this correct?
There was a problem hiding this comment.
It really should be under the /system guardian but if we're stuck with /user for now then that's a separate bug that'll need fixing.
There was a problem hiding this comment.
Agreed, this is an Akka core issue, not Akka.Hosting
There was a problem hiding this comment.
Could you please file a bug for that?
That might also be an ugly one to chase down if replicators are all currently hard-coded to look for /user/ paths for chatting. Might have to move that to a v1.6 issue if it ends up being a breaking behavioral change.
There was a problem hiding this comment.
Issue to track this created here: akkadotnet/akka.net#7606
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
LGTM but minor nitpicks
| var settings = ReplicatorSettings.Create(Sys); | ||
| var coordinatorName = settings.RestartReplicatorOnFailure ? $"{ReplicatorName}Supervisor" : ReplicatorName; | ||
|
|
||
| var actorSelection = Sys.ActorSelection(new RootActorPath(cluster.SelfAddress) / "user" / coordinatorName); |
There was a problem hiding this comment.
It really should be under the /system guardian but if we're stuck with /user for now then that's a separate bug that'll need fixing.
2 participants
Fixes #594
Changes
DistributedDataProviderto auto-start extension list inside theWithDistributedData()extension method.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):