feat: add name param to ToggleTerm and TermExec #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akinsho Assuming the CI failure here is some Actions config issue ? |
|
in the repo setting there secrets and variables |
|
Please don't touch anything in the repo workflow settings. I need to update some stuff when I have time but it shouldn't be done by PR contributors, thanks though. I'll review this PR properly when I get some time |
|
Thanks again for the PR 👍🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
nameparam to:ToggleTermand:TermExeccommands to allow setting thedisplay_namefor the terminal while creating it.Implements the feature I'd suggested here.
Let me know your thoughts. Thanks!