Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vim.diagnostic.is_disabled() deprecation warning (deprecated in neovim 0.10.0) #907

Merged
merged 1 commit into from
May 19, 2024

Conversation

fredrikaverpil
Copy link
Contributor

Why this change?

Avoid getting deprecation warnings.

What was changed?

  • Replaced vim.diagnostic.is_disabled() with vim.diagnostic.is_enabled().
  • Removed nil check.
  • Removed comment.

Notes

This requires Neovim 0.10.0: https://neovim.io/doc/user/news-0.10.html

@fredrikaverpil fredrikaverpil changed the title fix: vim.diagnostic.is_disabled() deprecation warning fix: vim.diagnostic.is_disabled() deprecation warning (deprecated in 0.10.0) May 18, 2024
@fredrikaverpil fredrikaverpil changed the title fix: vim.diagnostic.is_disabled() deprecation warning (deprecated in 0.10.0) fix: vim.diagnostic.is_disabled() deprecation warning (deprecated in neovim 0.10.0) May 18, 2024
@akinsho akinsho merged commit 2cd3984 into akinsho:main May 19, 2024
3 checks passed
@folke
Copy link

folke commented May 19, 2024

This breaks compatibility with Neovim 0.9.x

@akinsho
Copy link
Owner

akinsho commented May 20, 2024

I was hoping to avoid having to mediate both versions tbh and rely instead on people who are not ready not move up to stick to a certain version of bufferline where this is still supported. Just back from holiday and catching up on all these breakages so haven't had time to update the docs to point people towards a certain version number to use if you are unable to update to v10

@akinsho
Copy link
Owner

akinsho commented May 20, 2024

Thanks @fredrikaverpil that solves the issue either way 🙏🏾

sstallion pushed a commit to sstallion/bufferline.nvim that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants